create reusable workflow for docker build #584
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,6 @@ name: "Infra: Feature Testing: Init env" | |
|
|
||
| on: | ||
| workflow_dispatch: | ||
| pull_request: | ||
| types: ['labeled'] | ||
|
|
||
|
|
@@ -19,61 +18,42 @@ jobs: | |
| with: | ||
| ref: ${{ github.event.pull_request.head.sha }} | ||
| token: ${{ github.token }} | ||
|
|
||
| - name: get branch name | ||
| id: extract_branch | ||
| run: | | ||
| tag='pr${{ github.event.pull_request.number }}' | ||
| echo "tag=${tag}" >> $GITHUB_OUTPUT | ||
|
|
||
| - name: Set up JDK | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: '17' | ||
| distribution: 'zulu' | ||
| cache: 'maven' | ||
|
|
||
| - name: Build | ||
| id: build | ||
| run: | | ||
| ./mvnw -B -ntp versions:set -DnewVersion=$GITHUB_SHA | ||
| ./mvnw -B -V -ntp clean package -Pprod -DskipTests | ||
| export VERSION=$(./mvnw -q -Dexec.executable=echo -Dexec.args='${project.version}' --non-recursive exec:exec) | ||
| echo "version=${VERSION}" >> $GITHUB_OUTPUT | ||
|
|
||
| - name: Build and Push Docker Image | ||
| uses: ./.github/workflows/docker_build | ||
| with: | ||
| tag: ${{ steps.extract_branch.outputs.tag }} | ||
| version: ${{ steps.build.outputs.version }} | ||
| aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
| aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
| aws-region: eu-central-1 | ||
| repository: 297478128798.dkr.ecr.eu-central-1.amazonaws.com/kafka-ui | ||
|
Member
There was a problem hiding this comment. Do we need this? There's already an env var |
||
| build-context: api | ||
|
|
||
| outputs: | ||
| tag: ${{ steps.extract_branch.outputs.tag }} | ||
|
|
||
| make-branch-env: | ||
| needs: build | ||
| runs-on: ubuntu-latest | ||
|
|
@@ -89,7 +69,7 @@ jobs: | |
| git config --global user.email "[email protected]" | ||
| git config --global user.name "infra-tech" | ||
| git add ../kafka-ui-from-branch/ | ||
| git commit -m "added env:${{ needs.build.outputs.tag }}" && git push || true | ||
|
|
||
| - name: update status check for private deployment | ||
| if: ${{ github.event.label.name == 'status/feature_testing' }} | ||
|
|
@@ -98,7 +78,7 @@ jobs: | |
| authToken: ${{secrets.GITHUB_TOKEN}} | ||
| context: "Click Details button to open custom deployment page" | ||
| state: "success" | ||
| sha: ${{ github.event.pull_request.head.sha || github.sha }} | ||
| target_url: "http://${{ needs.build.outputs.tag }}.internal.ui.kafbat.dev" | ||
|
|
||
| - name: update status check for public deployment | ||
|
|
@@ -108,5 +88,5 @@ jobs: | |
| authToken: ${{secrets.GITHUB_TOKEN}} | ||
| context: "Click Details button to open custom deployment page" | ||
| state: "success" | ||
| sha: ${{ github.event.pull_request.head.sha || github.sha }} | ||
| target_url: "http://${{ needs.build.outputs.tag }}.internal.ui.kafbat.dev" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| name: "Infra: CVE checks" | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
|
|
@@ -17,6 +18,12 @@ jobs: | |
| with: | ||
| token: ${{ github.token }} | ||
|
|
||
| - name: get branch name | ||
| id: extract_branch | ||
| run: | | ||
| tag='build-${{ github.sha }}' | ||
| echo "tag=${tag}" >> $GITHUB_OUTPUT | ||
|
|
||
| - name: Set up JDK | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
|
|
@@ -32,34 +39,16 @@ jobs: | |
| export VERSION=$(./mvnw -q -Dexec.executable=echo -Dexec.args='${project.version}' --non-recursive exec:exec) | ||
| echo "version=${VERSION}" >> $GITHUB_OUTPUT | ||
|
|
||
| - name: Build Docker Image | ||
| uses: ./.github/workflows/docker_build | ||
| with: | ||
| tag: ${{ steps.extract_branch.outputs.tag }} | ||
| version: ${{ steps.build.outputs.version }} | ||
| aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
|
Member
There was a problem hiding this comment. This looks redundant since there's an existing secret |
||
| aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
| aws-region: eu-central-1 | ||
| repository: ghcr.io/kafbat/kafka-ui | ||
|
Member
There was a problem hiding this comment. given there are aws-related properties above, this looks like it should be AWS-related, why ghcr.io? |
||
| build-context: api | ||
|
|
||
| - name: Run CVE checks | ||
| uses: aquasecurity/[email protected] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an action like this is present in 4 workflows:
build-public-imagebranch-deployreleaseseparate_env_public_createThe point of Infra: Implement reusable workflows #117 was to reduce the amount of these things, can we extract them?