Skip to content

Conversation

@yeikel
Copy link
Collaborator

@yeikel yeikel commented Oct 28, 2024

What changes did you make? (Give an overview)

  • Updated the docker build to use the latest JRE version. We should do our best to have reproducible builds(pinning to a sha instead of a tag) but we do not have any specific dependency on Java 17.0.11
  • Updated the dependabot configuration to ensure that the docker image is updated automatically ignoring major upgrades (to avoid receiving a major Java upgrade as that will typically need more work)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

image

@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Oct 28, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi yeikel! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@yeikel yeikel changed the title Deps: Use latest jre image Chore: Deps: Use latest 17 jre image Oct 28, 2024
@yeikel yeikel marked this pull request as ready for review October 28, 2024 17:10
@yeikel yeikel requested review from a team as code owners October 28, 2024 17:10
@Haarolean Haarolean added scope/backend Related to backend changes type/dependencies A pull request/issue dedicated to updating the dependency(-ies) and removed status/triage/manual Manual triage in progress labels Oct 31, 2024
@Haarolean Haarolean added this to the 1.1 milestone Oct 31, 2024
@Haarolean Haarolean merged commit 5e510f9 into kafbat:main Nov 15, 2024
11 of 12 checks passed
@Haarolean
Copy link
Member

@yeikel thank you!

@yeikel yeikel deleted the patch-1 branch November 15, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope/backend Related to backend changes status/triage/completed Automatic triage completed type/dependencies A pull request/issue dedicated to updating the dependency(-ies)

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants