Skip to content

BE: Messages: Support sending null headers #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 17, 2024
Merged

BE: Messages: Support sending null headers #651

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
28190c8
fix #620 : support sending null headers in POST send message request
AkashDeepSinghJassal Nov 7, 2024
ebfd8e1
tests : added a send messsage test that verify null values in headers…
AkashDeepSinghJassal Nov 7, 2024
9416d33
Merge branch 'main' into issues/620
Haarolean Nov 9, 2024
3188223
Merge branch 'main' into issues/620
Haarolean Nov 11, 2024
14b5d46
Merge branch 'main' into issues/620
Haarolean Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/src/main/java/io/kafbat/ui/serdes/ProducerRecordCreator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public ProducerRecord<byte[], byte[]> create(String topic,

private Iterable<Header> createHeaders(Map<String, String> clientHeaders) {
RecordHeaders headers = new RecordHeaders();
clientHeaders.forEach((k, v) -> headers.add(new RecordHeader(k, v.getBytes())));
clientHeaders.forEach((k, v) -> headers.add(new RecordHeader(k, v == null ? null : v.getBytes())));
return headers;
}

Expand Down
20 changes: 20 additions & 0 deletions api/src/test/java/io/kafbat/ui/service/SendAndReadTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import io.kafbat.ui.serdes.builtin.StringSerde;
import io.kafbat.ui.serdes.builtin.sr.SchemaRegistrySerde;
import java.time.Duration;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.Objects;
Expand Down Expand Up @@ -425,6 +426,25 @@ void topicMessageMetadataJson() {
});
}

@Test
void headerValueNullPresentTest() {
new SendAndReadSpec()
.withKeySchema(JSON_SCHEMA)
.withValueSchema(JSON_SCHEMA)
.withMsgToSend(
new CreateTopicMessageDTO()
.key(JSON_SCHEMA_RECORD)
.keySerde(SchemaRegistrySerde.name())
.content(JSON_SCHEMA_RECORD)
.valueSerde(SchemaRegistrySerde.name())
.headers(Collections.singletonMap("header123", null))
)
.doAssert(polled -> {
assertThat(polled.getHeaders().get("header123")).isNull();
});
}


@Test
void noKeyAndNoContentPresentTest() {
new SendAndReadSpec()
Expand Down
Loading