Skip to content

Conversation

@horw
Copy link
Contributor

@horw horw commented Dec 17, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Updated link in Readme.md
Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@horw horw requested a review from a team as a code owner December 17, 2024 12:45
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Dec 17, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi horw! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@Haarolean Haarolean added type/chore Boring stuff, could be refactoring or tech debt impact/documentation A PR with changes which should be addressed in the documentation and removed status/triage/manual Manual triage in progress labels Dec 17, 2024
@Haarolean Haarolean merged commit 4bb3632 into kafbat:main Dec 17, 2024
7 of 8 checks passed
@Haarolean
Copy link
Member

@horw thanks!

K-Diger pushed a commit to K-Diger/kafbat-kafka-ui that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact/documentation A PR with changes which should be addressed in the documentation status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants