Skip to content

Conversation

@yeikel
Copy link
Collaborator

@yeikel yeikel commented Dec 23, 2024

What changes did you make? (Give an overview)

Before this change, the SchemaRegistryServiceTests tests were failing in Windows with the following exception:

image

	at org.springframework.beans.factory.support.ConstructorResolver.createArgumentArray(ConstructorResolver.java:782)
	... 55 more
Caused by: org.springframework.beans.BeanInstantiationException: Failed to instantiate [io.kafbat.ui.service.DeserializationService]: Constructor threw exception
	at org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:221)
	at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:117)
	at org.springframework.beans.factory.support.ConstructorResolver.instantiate(ConstructorResolver.java:315)
	... 69 more
Caused by: java.lang.NullPointerException: ProtoFile not found for import 'language/language.proto'
	at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:1011)
	at io.kafbat.ui.serdes.builtin.ProtobufFileSerde$ProtoSchemaLoader$1.load(ProtobufFileSerde.java:403)
	at com.squareup.wire.schema.Linker.getFileLinker$wire_schema(Linker.kt:95)

With this change, we are standardizing the import statements to remove backlashes in Windows which fixes the tests :

image

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • Manually (please, describe, if necessary)
  • Unit checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings (e.g. Sonar is happy)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

A picture of a cute animal (not mandatory but encouraged)
istockphoto-1243410279-612x612

@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Dec 23, 2024
@yeikel yeikel force-pushed the chore/standarize-path branch from e8c07c6 to 54381fe Compare December 23, 2024 17:18
@yeikel yeikel force-pushed the chore/standarize-path branch from 54381fe to c62d11b Compare December 23, 2024 17:19
@yeikel yeikel changed the title BE: standarize import paths BE: Chore: standarize import paths Dec 23, 2024
@yeikel yeikel marked this pull request as ready for review December 23, 2024 17:28
@yeikel yeikel requested a review from a team as a code owner December 23, 2024 17:28
@yeikel yeikel changed the title BE: Chore: standarize import paths BE: Chore: standarize Protobuff import paths Dec 23, 2024
@yeikel yeikel changed the title BE: Chore: standarize Protobuff import paths BE: Chore: standarize Protobuf import paths Dec 23, 2024
@Haarolean Haarolean added scope/backend Related to backend changes type/chore Boring stuff, could be refactoring or tech debt and removed status/triage/manual Manual triage in progress labels Dec 28, 2024
@Haarolean Haarolean self-requested a review December 28, 2024 04:53
@Haarolean Haarolean merged commit 64f63d1 into kafbat:main Dec 28, 2024
5 of 6 checks passed
@Haarolean Haarolean added this to the 1.1 milestone Dec 28, 2024
@yeikel yeikel deleted the chore/standarize-path branch February 5, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope/backend Related to backend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants