Skip to content

Conversation

@ryanjclark
Copy link

@ryanjclark ryanjclark commented Dec 27, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make?
I added the quick fix recommended in #239; allowing max-content for width and capping it at 280px.

It allows for long Kafka cluster names but won't ruin the UI in the case of a very long name.

Is there anything you'd like reviewers to focus on?
This feels good enough to close #239 while still allowing room for #528. Check out the picture to see how it looks.

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

image

@ryanjclark ryanjclark requested a review from a team as a code owner December 27, 2024 19:40
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Dec 27, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi ryanjclark! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

Copy link
Member

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to our design, the sidebar width currently is 240px. The issue with long cluster names should be solved using this design approach rather than this hammer fix.
P.S. Please note that there has been another PR open on this matter (#823), I left the same comment there.

@kapybro
Copy link

kapybro bot commented Feb 28, 2025

Further user feedback is requested. Please reply within 7 days or we might close the issue.

@kapybro
Copy link

kapybro bot commented Mar 7, 2025

No feedback received within 7 days. Auto closing.

@kapybro kapybro bot closed this Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UX: Allow expandable menu width

2 participants