Skip to content

Conversation

@Brijeshthummar02
Copy link
Contributor

@Brijeshthummar02 Brijeshthummar02 commented Mar 16, 2025

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

fixes #921

details :

uses: actions/checkout@v4

to

uses: actions/checkout@1e31de5234b9f8995739874a8ce0492dc87873e2
uses: actions/setup-java@v4

to

uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12
uses: actions/cache@v4

to

uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf
uses: actions/download-artifact@v4

to

uses: actions/download-artifact@cc203385981b70ca67e1cc392babf9cc229d5806
uses: actions/upload-artifact@v4

to

uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1
uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502  # infered from @v4
uses: aws-actions/amazon-ecr-login@9238dd443b7a5941caf19ffbe68be34d4dbd61df # infered from @v4
 uses: mheap/github-action-required-labels@388fd6af37b34cdfe5a23b37060e763217e58b03 # infered from @v5
uses: docker/setup-qemu-action@29109295f81e9208d7d86ff1c6c12d2833863392 # infered from @v3
 uses: docker/setup-buildx-action@b5ca514318bd6ebac0fb2aedd5d36ec1b5c232a2 # infered from @v3
uses: docker/build-push-action@471d1dc4e07e5cdedd4c2171150001c434f0b7a4 # infered from @v6
uses: Sibz/github-status-action@650dd1a882a76dbbbc4576fb5974b8d22f29847f # infered from @v1.1.6
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 # infered from @v4
 uses: github/codeql-action/autobuild@bed2a47f201e917459bc40343380c570a730ff06 # infered from @v3
uses: github/codeql-action/analyze@86b04fb0e47484f7282357688f21d5d0e32175fe # infered from @v3
uses: aquasecurity/trivy-action@18f2510ee396bbf400402947b394f2dd8c87dbb0 # infered from @v0.29.0
uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # infered from @v3
uses: ScribeMD/docker-cache@fb28c93772363301b8d0a6072ce850224b73f74e # infered from @v0.5.0
 uses: jwalton/gh-docker-logs@2741064ab9d7af54b0b1ffb6076cf64c16f0220e # infered from @v2.2.2
uses: github/codeql-action/init@1a7989f3955e0c69f0e0ccc14aee54a387a0fd31 # infered from @v3
uses: simple-elf/allure-report-action@58e6590adf6d8f196a0d771bf8a00e6921086a62 # infered from @v1.9
uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # infered from @v4.1.0
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # infered from @v4.0.2
uses: Ilshidur/action-discord@0c4b27844ba47cb1c7bee539c8eead5284ce9fa9 # infered from @v0.3.2
uses: urlstechie/urlchecker-action@b643b43e2ac605e1475331c7b67247d242b7dce4 # infered from @v0.0.34
 uses: kentaro-m/task-completed-checker-action@2ddb65fdd5577bae4a8e82e0564e459677aec893 # infered from @v0.1.2
uses: dekinderfiets/pr-description-enforcer@f6a858878d694ff5b2760380fbcd21129030c5dd # infered from @v0.0.1
uses: release-drafter/release-drafter@3f0f87098bd6b5c5b9a36d49c41d998ea58f9348 # infered from @v6
uses: svenstaro/upload-release-action@04733e069f2d7f7f0b4aebc4fbdbce8613b03ccd # infered from @v2.9.0
uses: peter-evans/repository-dispatch@ff45666b9427631e3450c54a1bcbee4d9ff4d7c0 # infered from @v3
uses: actions/first-interaction@3c71ce730280171fd1cfb57c00c774f8998586f7 # infered from @v1
uses: crazy-max/ghaction-setup-docker@635d07c09dc2b52072362e9bb37e7e789767106d # infered from @v3

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Brijeshthummar02 Brijeshthummar02 requested a review from a team as a code owner March 16, 2025 16:32
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Mar 16, 2025
@Brijeshthummar02
Copy link
Contributor Author

Brijeshthummar02 commented Mar 16, 2025

@Haarolean as mentioned i gone through all the workflows file and updated @v4 to its specific SHA commits from github actions all changes are mentioned in PR body, have a look to it and if furthermore if any specific version needs to be updated kindly mention it.

NOTE*
Also i have used latest commit of v4.

Copy link
Member

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. There's still a ton of other actions untouched, some examples:
    uses: aws-actions/configure-aws-credentials@v4
    uses: aws-actions/amazon-ecr-login@v2
  2. Could you please leave a comment next to each action commit which tag it was infered from? like actions/[email protected] # @v4

@Brijeshthummar02
Copy link
Contributor Author

@Haarolean help me out i cannot find for uses: crazy-max/ghaction-setup-docker@v3 provide me. almost all actions have been updated just going through changes.

@Brijeshthummar02
Copy link
Contributor Author

@Haarolean gone through the remaining actions and updated it to relevent sha. if any changes req. mention it.

@Haarolean
Copy link
Member

@Haarolean help me out i cannot find for uses: crazy-max/ghaction-setup-docker@v3 provide me. almost all actions have been updated just going through changes.

https://github.com/crazy-max/ghaction-setup-docker redirects to https://github.com/docker/setup-docker-action,
required tag could be found in their releases: https://github.com/docker/setup-docker-action/releases

@Brijeshthummar02
Copy link
Contributor Author

@Haarolean best of mine i have updated all @v to its specific versions of actions.

@Haarolean Haarolean added scope/infra CI, CD, dev. env, etc. type/security Pull requests that address a security vulnerability and removed status/triage/manual Manual triage in progress labels Mar 17, 2025
@Brijeshthummar02
Copy link
Contributor Author

@Haarolean we can trigger req. workflows.

@Haarolean Haarolean added this to the 1.3 milestone Mar 21, 2025
@Brijeshthummar02
Copy link
Contributor Author

@Haarolean quick check is everything okay related to this PR, do it need further changes?

@Haarolean Haarolean moved this to Todo in Release 1.3 Mar 22, 2025
@Haarolean Haarolean moved this from Todo to In Development in Release 1.3 Mar 22, 2025
@Haarolean Haarolean merged commit 6fa339f into kafbat:main Mar 22, 2025
4 of 5 checks passed
@github-project-automation github-project-automation bot moved this from In Development to Done in Release 1.3 Mar 22, 2025
@Haarolean
Copy link
Member

@Brijeshthummar02 thanks for your contribution!

@Brijeshthummar02 Brijeshthummar02 deleted the issues/921 branch March 22, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed type/security Pull requests that address a security vulnerability

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Infra: Pin workflow actions to commit versions

2 participants