Skip to content

Conversation

@stumbaumr
Copy link

The parameter className ist missing here...

Missing parameter...
Copy link
Member

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me know if that's not the case

serde:
- name: ProtobufFile
properties:
className: io.kafbat.ui.serdes.builtin.ProtobufFileSerde
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be needed as proto is a built-in serde, given the name stays as is, no classname should be specified (io/kafbat/ui/serdes/SerdesInitializer.java:44)

@stumbaumr
Copy link
Author

You are correct. At first I used custom names, then was wondering why it did not work and then read the comment in the source code and changed the name accordingly.
Maybe cut&paste the comment from the source code into the documentation or at least link to it.
Took me some time to get past this configuration error.

@Haarolean
Copy link
Member

You are correct. At first I used custom names, then was wondering why it did not work and then read the comment in the source code and changed the name accordingly. Maybe cut&paste the comment from the source code into the documentation or at least link to it. Took me some time to get past this configuration error.

could you leave a comment then? Like
className: io.kafbat.ui.serdes.builtin.ProtobufFileSerde # not needed unless a custom name is used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants