chore: replace bun with node since bun keeps crashing#1467
Draft
supreme-gg-gg wants to merge 2 commits intokagent-dev:mainfrom
Draft
chore: replace bun with node since bun keeps crashing#1467supreme-gg-gg wants to merge 2 commits intokagent-dev:mainfrom
supreme-gg-gg wants to merge 2 commits intokagent-dev:mainfrom
Conversation
Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io>
supreme-gg-gg
requested review from
EItanya,
ilackarms,
peterj and
yuval-k
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces Bun-based UI build/runtime steps with Node.js/npm to mitigate intermittent Bun crashes in CI and standardize UI container builds.
Changes:
- Switch Next.js runtime execution from
buntonodeunder supervisord. - Update UI developer Makefile targets from Bun to npm equivalents.
- Replace Bun installation and build steps in the UI Dockerfile with Node.js/npm.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| ui/conf/supervisord.conf | Runs the Next.js standalone server with node and removes Bun-specific PATH entries. |
| ui/Makefile | Uses npm ci / npm run build / npm audit instead of Bun commands. |
| ui/Dockerfile | Removes Bun install, installs Node.js/npm via apk, and builds the UI using npm. |
| Makefile | Drops Bun tool version/build-arg wiring from the root build args. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1331