Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a global bound for 3-clause for loops to guarantee boundedness.
Bounded for loops with global bounds
In general, 3-clause for loops are not guaranteed to terminate within a finite amount of time. To guarantee their boundedness, a global bound is implemented. This adds a constraint to the total number of iterations of all 3-clause for loops in a P4 program execution.
To keep track of the total number of iterations, a loop counter variable is added to
evalContext:The loop bound is defined as 1000 for now.
update_loop_count_e()is a helper function that increments the loop counter in the context. It also checks whether the counter exceeds the global bound.relation ForThreeClauseLoop_evalcalls this function on each iteration.Additionally, rules implementing the relation
Call_evalare modified to capture the iterations executed in callees' bodies by using the helper function$merge_loop_count_e().Testcase
testdata/custom/for-global-bound.p4is a testcase that satisfies the constraints.Since the number of total iterations is less than 1000, this is considered a legal program. However, for example, if the for loop in
foo()is modified to iterate 100 times instead of 10, the number of total iterations would be greater than 1000 and this would be considered as an error.