Fix Slf4j-api module, to better represent the Java 9 compatible module name#245
Open
Fix Slf4j-api module, to better represent the Java 9 compatible module name#245
Conversation
change slf4j module, to represent the designed module name, instead of the artifact name
Owner
|
logback 1.0.0 that's used for Pcap4J testing doesn't work with SLF4J 1.8. |
|
I encounter the same issue. Could you try using This contains the module-info with the name |
|
There is a newer logback version available that uses SLF4J 2.0: "Latest STABLE version EXPERIMENTAL/UNSTABLE requiring SLF4J version 2.0.x @kaitoy Would you be willing to try it out? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The currently used
slf4j-apiversion (1.7.26) has not been made with the new modular system of Java 9 in mind. This means that there isn't amodule-info.javafile in the provided dependency.To overcome this, in the
org.pcap4j.coremodule, the artifact id of theslf4j-apihas been required.This, however, isn't compatible with the modular version of
slf4j-api, which means that users of this (pcap4j) artifact cannot make use of the modular slf4j version, because, during compile, therequires transitive slf4j.api;requirement will not be met by the modularslf4j-apiversion.For this reason, I raised the
slf4j-apiversion in the parent POM and made it so that theorg.pcap4j.coremodule requires the intendedorg.slf4jmodule instead.