Multihypervisor/3 handler backup 02232026#112
Draft
harshitgupta1337 wants to merge 16 commits intomainfrom
Draft
Multihypervisor/3 handler backup 02232026#112harshitgupta1337 wants to merge 16 commits intomainfrom
harshitgupta1337 wants to merge 16 commits intomainfrom
Conversation
Move tests/vmi_multiqueue_test.go to tests/network/multiqueue.go and modernize the code to use libvmi primitives. Add InterfaceWithModel() helper to pkg/libvmi/network.go. Assisted-by: claude-sonnet-4-5 Signed-off-by: Dan Kenigsberg <danken@redhat.com>
Allow overriding the images of virt-template-apiserver and virt-template-controller from the KubeVirtDeploymentConfig. Also allow overriding them from the virt-operator CSV. Assisted-by: Claude <noreply@anthropic.com> Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
Alpinetesttooling is enabled for s390x, this commit adds the s390x label to the test files. This ensures that the tests are correctly tagged and executed for the s390x architecture. Signed-off-by: Laxmi Adavalli <laxmi.adavalli@ibm.com>
Performs KernelBoot from a specialised minimal guest image, when trying to bring up a Guestless VMI on s390x. Signed-off-by: Thomas-David Griedel griedel911@gmail.com
[056f8f7 Run go run ./robots/kubevirtci-bumper -ensure-only-latest-three --k8s-provider-dir /home/prow/go/src/github.com/kubevirt/project-infra/../kubevirtci/cluster-provision/k8s --cluster-up-dir /home/prow/go/src/github.com/kubevirt/project-infra/../kubevirtci/cluster-up/cluster](kubevirt/kubevirtci#1629) [52788b7 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1626) ```release-note NONE ``` Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
Multiple controllers in virt-handler are instantiated before the ClusterConfig informer and other informers have synced. This lets the Controllers be instantiated with the actual cluster config from the CR instead of being instantiated with default config and being updated later via callbacks. Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
Depending on whether the VMI is running or not, the PID chosen to update memlock limit is qemu-* or virtqemud. This commit adds a single logic both those cases by just querying the right PID based on VMI status. Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
Add a member of the interface type to the BaseController to be accessed from VM, Migr-target and Migr-src controllers. Use the interface impl to query hypervisor device info to add to cgroup device allow-list. Also, compute the device rule permissions using a helper function to deduplicate logic. Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
GetQemuProcess and KvmPitPid functions in the IsolationResult interface rely on Pid and PPid fns. As such, they don't form the core function of the IsolationResult interface. Move them out of the interface to make the interface leaner. Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
Move the adjustQemuProcessMemoryLimits fn to vm.go to facilitate subsequent changes for introduction of VirtRuntime. Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
Move non-housekeeping related logic out of the HandleHousekeeping function. Change the fn signature to avoid repeated cache lookup for domain. Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
Define the VirtRuntime interface and declare it as a member of the BaseController struct in virt-handler. Initialize the VirtRuntime based on the hypervisor configured in the cluster config. Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
Move the hypervisor-related logic in virt-handler to KVM's Runtime implementation. Update virt-handler logic to invoke the hypervisor runtime. Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
After this PR:
References
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note