부산대_ BE_ 이성훈 6주차 (2단계)#315
Open
NextrPlue wants to merge 37 commits intokakao-tech-campus-2nd-step2:nextrpluefrom
Open
부산대_ BE_ 이성훈 6주차 (2단계)#315NextrPlue wants to merge 37 commits intokakao-tech-campus-2nd-step2:nextrpluefrom
NextrPlue wants to merge 37 commits intokakao-tech-campus-2nd-step2:nextrpluefrom
Conversation
cmst-steve
approved these changes
Aug 3, 2024
cmst-steve
left a comment
cmst-steve
left a comment
There was a problem hiding this comment.
1단계에서 리뷰드린 내용 잘 적용해주시면 좋을 것 같습니다.
1단계와 리뷰드릴 내용이 같아 머지하겠습니다~
| return name; | ||
| } | ||
|
|
||
| public void setName(String name) { |
There was a problem hiding this comment.
setter는 그냥 습관처럼 만들기보다는 필요한 경우에만 만들어주는게 좋습니다.
|
@NextrPlue 컨플릭 해결후 디엠주세요~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
과제 제출을 위한 선 pr입니다.