Conversation
|
Thank you! Will check it soon. |
|
@mxr For me, the whole "graph" functionality (described in a For now, I think this PR achieved it's minimal goal (per-entity option). |
|
Thanks for the feedback. I implemented it in mxr@6518e8b (GitHub seems to be lagging so I amended the prior commit)
I have an example in the PR description. Let me know if I misunderstood. |
6518e8b to
9dfd832
Compare
|
I totally understood your example, I meant a technical implementation of the Graph class itself. Repeat, the PR looks fine, but since personally me may not know some details of Graph class, I am not sure that the whole logarithmic thing works properly. Let’s merge and then test. |
Adds per-entity logarithmic configuration so mixed-scale graphs work correctly.
Specifying 'secondary' for the y-axis isn't enough for my use-case. I have a graph with two waveforms: one waveform is brightness on the primary y-axis (roughly 1 to 5000), while another waveform is sunrise/sunset on the secondary y-axis (boolean 0/1). With only global
logarithmic: true, the sunrise/sunset waveform breaks; this change allows keeping brightness logarithmic while leaving sunrise/sunset linear via entity-level override.Resolves #862
logarithmic: trueglobally doesn't work