Skip to content

Fix core unit tests failing#420

Open
djarran wants to merge 1 commit intokaltura:MOODLE_401_STABLEfrom
djarran:MOODLE_401_STABLE_issue_394
Open

Fix core unit tests failing#420
djarran wants to merge 1 commit intokaltura:MOODLE_401_STABLEfrom
djarran:MOODLE_401_STABLE_issue_394

Conversation

@djarran
Copy link

@djarran djarran commented Feb 13, 2024

Description: This applies the fixes outlined in #394. This fails this test with the following error message:

1) externallib_test::test_get_courses_by_field
Failed asserting that actual size 7 matches expected size 6.

/var/www/site/course/tests/externallib_test.php:2800
/var/www/site/lib/phpunit/classes/advanced_testcase.php:80

This proposed fix allows the unit test to be ran successfully

@kaltura-hooks
Copy link

Hi @djarran,
Thank you for contributing this pull request!
Please sign the Kaltura CLA so we can review and merge your contribution.
Learn more at http://bit.ly/KalturaContrib

@golenkovm
Copy link

Hi @kaltura-hooks and Kaltura team,

Is there a chance this could be integrated? The patch looks to be spot on.

Kind regards,
Misha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants