fix(SUP-51658): Player downloads not opening#277
Open
inbalvasserman wants to merge 1 commit intomasterfrom
Open
fix(SUP-51658): Player downloads not opening#277inbalvasserman wants to merge 1 commit intomasterfrom
inbalvasserman wants to merge 1 commit intomasterfrom
Conversation
SivanA-Kaltura
requested changes
Mar 9, 2026
| * @returns {Promise} Promise | ||
| */ | ||
| public fetchData(requestsMustSucceed?: boolean): Promise<any> { | ||
| public fetchData(requestsMustSucceed?: boolean, filterErrorResults?: boolean): Promise<any> { |
Collaborator
There was a problem hiding this comment.
can you make the arguments non optional or does it not handle the case of OTT ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue:
download docx file for a costumer did not open correctly
root cause:
when do call for downloads items and get result with an error for some asset, the results mapping was wrong and mixed the asset id with url, after the error results was filtered out.
solution:
add flag if to remove error results
this pr is part of: kaltura/playkit-js-downloads#91
resolve SUP-51658