Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
- Coverage 32.58% 32.26% -0.32%
==========================================
Files 29 29
Lines 2833 2907 +74
==========================================
+ Hits 923 938 +15
- Misses 1802 1862 +60
+ Partials 108 107 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM. Expands core “gather/observe” behavior to support in-progress workflow runs and adds new UI rendering paths.
Changes:
- Allow gathering workflow runs that are not yet completed (skip billing/monitoring and avoid local caching).
- Surface
in_progress/queuedstates in observation data and timelines (including a runtime table + queued list in the UI). - Improve CLI/README/agent documentation examples and descriptions.
Reviewed changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
gather/workflow_run.go |
Allows in-progress runs; conditionally skips billing/monitoring/caching. |
gather/commit.go |
Includes non-completed check runs when deriving workflow run IDs and conclusions. |
observe/workflow_run.go |
Uses status as a fallback state when conclusion is empty. |
observe/job_runs.go |
Uses status as a fallback state; renders queued/in-progress steps. |
observe/commit.go |
Renders queued/in-progress workflow runs in timelines. |
observe/timeline.go |
Adds QueuedItems and duration-sorted view helper. |
observe/templates/timeline.html |
Adds “Runtimes” table and “Queued” section to timeline UI. |
observe/templates/styles.css |
Styles for the new runtime table/badges. |
observe/templates/observation.html |
Adds Mermaid theme colors for active tasks. |
report/report.go |
Falls back to monitor-derived job name when missing from GHA env. |
report/github.go |
Adds pagination and stricter “job not found” handling for job-step lookup. |
cmd/gather.go |
Expands help text/examples; notes in-progress workflow support. |
cmd/observe.go |
Expands help text. |
cmd/monitor.go |
Expands help text/examples. |
README.md |
Updates screenshot reference and adds install/usage examples. |
AGENTS.md |
Formatting tweaks and adds pre-commit note. |
Comments suppressed due to low confidence (1)
gather/commit.go:333
- Now that non-completed/queued workflow runs can be included,
workflowRun.GetRunStartedAt()may be zero (e.g., queued runs). The current update logic can setcommitData.StartActionsTimeto the zero time, which can break downstream duration calculations and timelines. Consider skipping the StartActionsTime update whenGetRunStartedAt().IsZero()(and similarly guard other time aggregations if needed).
commitData.Conclusion = establishPRChecksConclusion(commitData.Conclusion, conclusion)
commitData.Cost += workflowRun.GetCost()
if workflowRun.GetRunStartedAt().Before(commitData.StartActionsTime) ||
commitData.StartActionsTime.IsZero() {
commitData.StartActionsTime = workflowRun.GetRunStartedAt().Time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer error when finding a currently running workflow. Instead, display a warning. Also show it as running in observation data.
Also improve some docs.