Skip to content

Conversation

@kalwalt
Copy link
Owner

@kalwalt kalwalt commented May 28, 2019

My goal is to make a stable NFT branch;

  • updating to the latest artoolkit5
  • upgrading all the methods
  • improving and finding the bottlneck in the code
  • restoring the wasm example
  • fixing the FS not defined issue
  • upgrading the Three.js version to r103
  • restoring the webWorker version
  • enhance the disappearing of objects when marker is lost: showing only after some ms
  • enhance the disappearing of objects when marker is lost: show only if content was visible
  • make it working always on mobile phones
  • merge @misdake modifies and examples
  • add a screen loader for first NFT data loading time (like opacity + loading message + AR.js logo). should be added/removed as property AR.js
  • try a first example of AR.js using this NFT version of jsartoolkit5
  • test and make it works the emscripten compilation also for Windows.
  • enhance loader time of disappearing at initial loading

For anyone interested to try and to build the lib:
The jsartoolkit is based on the emscripten compiler, you need to install it in your machine, follow these instructions: https://emscripten.org/docs/getting_started/downloads.html. i used emscripten 1.38.31 1.38.44-fastcomp 1.39.5-fastcomp. Read this issue #11 regarding
emscripten. We not recommend to use emscripten directly but instead use Docker as described in the Readme.md in this chapter recommended-build-using-docker

Testing page

https://kalwalt.github.io/jsartoolkit5/examples/

ThorstenBux and others added 30 commits January 11, 2018 13:31
Merge branch 'typescript' into ts-fromCommunity

* typescript:
  threejs integration
  fix getMarker return type
  ARMarkerInfo class
  update  type defs
  update versıon and publish
  export necessary modules for typescript
  type defs for artoolkit.api

# Conflicts:
#	build/artoolkit.debug.js
Merge branch 'typescript' into ts-fromCommunity

* typescript:
  threejs integration
  fix getMarker return type
  ARMarkerInfo class
  update  type defs
  update versıon and publish
  export necessary modules for typescript
  type defs for artoolkit.api

# Conflicts:
#	build/artoolkit.debug.js
Fixed issue with artoolkit.setup not a function
Fixed runtime error

Commit new compiled files
Added tests for wasm support
Documented how wasm can be used
@kalwalt
Copy link
Owner Author

kalwalt commented Jan 10, 2020

@nicolocarpignoli @ThorstenBux we should transform the ES6 syntax used in some nft examples to the ES5 standard. i think it's a bit confusing. I have nothing in contrary in rispect to ES6 standard but there are good reasons to avoid to use:
Emscripten parser can not parse ES6 features
and for AR.js uglifyjs has also issues. So i suggest to change the code used in the most of the nft examples to the ES5 standard.

@kalwalt
Copy link
Owner Author

kalwalt commented Jan 17, 2020

We could had an error handling at the end of the getUserMedia function:

navigator.mediaDevices.getUserMedia( hint ).then( function( stream ) {

  // video code

}).catch(function(err) { 

         console.log(err.name + ": " + err.message);

});

inside the nft examples,

@kalwalt
Copy link
Owner Author

kalwalt commented Jan 22, 2020

This was merged in the https://github.com/artoolkitx/jsartoolkit5 master branch ! Probably i will close this PR.

@nicolocarpignoli
Copy link
Collaborator

@kalwalt Yes I think we can merge this one in the 'master' branch of your jsartoolkit5. The missing checklist points will be handled elsewhere :)

@kalwalt
Copy link
Owner Author

kalwalt commented Jan 25, 2020

@nicolocarpignoli my master is already in sync with the latest form artoolkitx/jsartoolkit5 i can't merge this PR into my master because there are no other commits, so i will simply close.

@kalwalt kalwalt closed this Jan 25, 2020
@manojahuja11
Copy link

Hi @kalwalt @nicolocarpignoli @ThorstenBux.

Hope you all are doing well. Great work guys. Congratulations!!!

I tested your examples.
I can run "main_threejs_wasm_worker.html" without any errors and I can see the sphere with my custom image.

Remaining 4 scripts which are:

  1. "threejs_worker_gltf.html"
  2. "main_threejs_worker.html"
  3. "main.html"
  4. "main_worker.html"

All gives common error which is: Uncaught SyntaxError: Unexpected end of input
at artoolkit.worker.js:1 @ /build/artoolkit.min.js: 13

and additionally, main.html also throws : main.js:108 Uncaught ReferenceError: ARCameraParam is not defined
at load (main.js:108)
at start (main.js:199)
at HTMLVideoElement. (main.html:52) main.js:108

Please help guys.
Thanks in advamce

@kalwalt
Copy link
Owner Author

kalwalt commented Jan 27, 2020

@manojahuja11 i opened an issue #35, i will check when i have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C/C++ coding with C and C++ language code design enhancement New feature or request javascript all about javascript code NFT nft markerless technology

Projects

None yet

Development

Successfully merging this pull request may close these issues.