Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the project's type checking infrastructure from mypy to ty, a newer type checker. The changes involve updating dependencies, configuration files, documentation, tooling, and adding type annotations to resolve compatibility issues with the new type checker.
- Replaces mypy (v1.15.0) with ty (v0.0.4) in project dependencies
- Updates configuration from
[tool.mypy]to[tool.ty]in pyproject.toml - Adds class-level attribute annotations with
type: ignore[unresolved-attribute]comments in source files to satisfy ty's type checking requirements
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Removes mypy and mypy-extensions package definitions, adds ty package (v0.0.4) with platform-specific wheels |
| pyproject.toml | Removes mypy dependency and configuration section, adds ty dependency, removes D407 ruff ignore rule, adds empty [tool.ty] section |
| src/recovery/utils.py | Adds class attribute type annotations for OrthogonalFactorLoss with type: ignore comments on assignments |
| src/models/softmax_bottleneck_model.py | Adds class attribute type annotations for SoftmaxBottleneckModel with type: ignore comments on assignments |
| docs/usage.md | Updates command reference from make mypy to make ty |
| docs/installation.md | Updates command reference from make mypy to make ty |
| Makefile | Renames mypy target to ty, updates command syntax with different exclude pattern |
| .gitignore | Changes cache directory from .mypy_cache to .ty_cache |
| .github/workflows/code-quality.yml | Updates CI workflow to run make ty instead of make mypy |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.