Skip to content

Enable warnings in CI #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niklas-uhl merged 2 commits into from
Aug 20, 2025
Merged

Enable warnings in CI #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69c863e
Build with warnings enabled and as errors.
niklas-uhl Aug 20, 2025
580b232
Silence unused variable warning.
niklas-uhl Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/cmake-single-platform.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,13 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: mpi4py/setup-mpi@v1
with:
mpi: mpich

- name: Configure CMake
# Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make.
# See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type
run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}}
run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DCMAKE_CXX_FLAGS='-Wall -Wextra -pedantic' -DCMAKE_COMPILE_WARNING_AS_ERROR=ON

- name: Build
# Build your program with the given configuration
Expand All @@ -36,5 +38,5 @@ jobs:
working-directory: ${{github.workspace}}/build
# Execute tests defined by the CMake configuration.
# See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail
run: ctest -C ${{env.BUILD_TYPE}}
run: ctest -C ${{env.BUILD_TYPE}} --output-on-failure

16 changes: 10 additions & 6 deletions gtest-mpi-listener.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ class MPIEnvironment : public ::testing::Environment {

private:
// Disallow copying
MPIEnvironment(MPIEnvironment const& env) {}
MPIEnvironment(MPIEnvironment const&) {}

}; // class MPIEnvironment

Expand All @@ -110,7 +110,8 @@ class MPIMinimalistPrinter : public ::testing::EmptyTestEventListener {
public:
MPIMinimalistPrinter() : ::testing::EmptyTestEventListener(), result_vector() {
int is_mpi_initialized;
int return_code = MPI_Initialized(&is_mpi_initialized);
int return_code = MPI_Initialized(&is_mpi_initialized);
static_cast<void>(return_code);
assert(return_code == MPI_SUCCESS);
if (!is_mpi_initialized) {
printf("MPI must be initialized before RUN_ALL_TESTS!\n");
Expand All @@ -124,7 +125,8 @@ class MPIMinimalistPrinter : public ::testing::EmptyTestEventListener {

MPIMinimalistPrinter(MPI_Comm comm_) : ::testing::EmptyTestEventListener(), result_vector() {
int is_mpi_initialized;
int return_code = MPI_Initialized(&is_mpi_initialized);
int return_code = MPI_Initialized(&is_mpi_initialized);
static_cast<void>(return_code);
assert(return_code == MPI_SUCCESS);
if (!is_mpi_initialized) {
printf("MPI must be initialized before RUN_ALL_TESTS!\n");
Expand All @@ -140,6 +142,7 @@ class MPIMinimalistPrinter : public ::testing::EmptyTestEventListener {
MPIMinimalistPrinter(MPIMinimalistPrinter const& printer) {
int is_mpi_initialized;
int return_code = MPI_Initialized(&is_mpi_initialized);
static_cast<void>(return_code);
assert(return_code == MPI_SUCCESS);
if (!is_mpi_initialized) {
printf("MPI must be initialized before RUN_ALL_TESTS!\n");
Expand All @@ -157,6 +160,7 @@ class MPIMinimalistPrinter : public ::testing::EmptyTestEventListener {
void OnEnvironmentTearDownStart() {
int is_mpi_finalized;
int return_code = MPI_Finalized(&is_mpi_finalized);
static_cast<void>(return_code);
assert(return_code == MPI_SUCCESS);
if (!is_mpi_finalized) {
MPI_Comm_free(&comm);
Expand Down Expand Up @@ -279,7 +283,7 @@ class MPIWrapperPrinter : public ::testing::TestEventListener {
listener(l),
result_vector() {
int is_mpi_initialized;
int return_code = MPI_Initialized(&is_mpi_initialized);
int return_code [[maybe_unused]] = MPI_Initialized(&is_mpi_initialized);
assert(return_code == MPI_SUCCESS);
if (!is_mpi_initialized) {
printf("MPI must be initialized before RUN_ALL_TESTS!\n");
Expand All @@ -296,7 +300,7 @@ class MPIWrapperPrinter : public ::testing::TestEventListener {
: listener(printer.listener),
result_vector(printer.result_vector) {
int is_mpi_initialized;
int return_code = MPI_Initialized(&is_mpi_initialized);
int return_code [[maybe_unused]] = MPI_Initialized(&is_mpi_initialized);
assert(return_code == MPI_SUCCESS);
if (!is_mpi_initialized) {
printf("MPI must be initialized before RUN_ALL_TESTS!\n");
Expand Down Expand Up @@ -461,7 +465,7 @@ class MPIWrapperPrinter : public ::testing::TestEventListener {
// Called before the Environment is torn down.
virtual void OnEnvironmentsTearDownStart(::testing::UnitTest const& unit_test) {
int is_mpi_finalized;
int return_code = MPI_Finalized(&is_mpi_finalized);
int return_code [[maybe_unused]] = MPI_Finalized(&is_mpi_finalized);
assert(return_code == MPI_SUCCESS);
if (!is_mpi_finalized) {
MPI_Comm_free(&comm);
Expand Down