Second Lua implementation (Lua.2)#630
Open
cheminDeFer wants to merge 25 commits intokanaka:masterfrom
Open
Conversation
Internal representation of strings obtained via not escaping during scanning because escaping mutates the string which causes second read of string gives different result. `time`, `meta`, `with-meta` builtins are added. Dockerfile and READMEs updated/added.
builtin conj, seq added bug fixes in with-meta, defmacro! string
kanaka
requested changes
Aug 7, 2024
Owner
kanaka
left a comment
kanaka
left a comment
There was a problem hiding this comment.
Hello @cheminDeFer sorry for the very slow reply (I've been unable to work on this project for the past couple of years but I'm am now able to again). If you're still interested in getting this merged upstream I would ask that you do the following:
- Rebase the code onto the current HEAD
- The recommended process has changed slightly: the eval_ast is no longer seperate from eval and macroexpand is not longer a standalone function. It would be good if you could update to follow the new structure.
- Add your implementation to
IMPLS.ymland make sure that the Github Actions CI tests all pass for your implementation.
kanaka
added
the
new_implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major difference from first Lua implementation is tokenisation is done manually instead of using regular expressions.