Conversation
board table. refactor: board repo for isArchived filtering
* Implemented a Listbox for mobile and a tabbed navigation for desktop to switch between "Boards" and "Archived" views. * Introduced state management for active tab selection. * Updated UI components to reflect the new navigation structure.
apps/web/src/locales/de/messages.po
Outdated
| "Plural-Forms: \n" | ||
|
|
||
| #: src/views/card/components/Comment.tsx:130 | ||
| #: src/views/card/components/Comment.tsx:153 |
There was a problem hiding this comment.
Translations are now handled by the translate workflow so need to add anything here (unless you want to change the wording of an existing translations).
Please could you revert and changes under /locales (sorry to be a pain) @eliott-herbert-byrnes
packages/api/src/routers/board.ts
Outdated
| @@ -683,4 +665,118 @@ export const boardRouter = createTRPCRouter({ | |||
| isReserved: !isBoardSlugAvailable, | |||
| }; | |||
| }), | |||
| archive: protectedProcedure | |||
There was a problem hiding this comment.
As we're only toggling the isArchived column, I think we should try to use the existing update endpoint (should really be PATCH) for archiving/unarchiving
| sourceBoardId: bigint("sourceBoardId", { mode: "number" }), | ||
| }, | ||
| (table) => [ | ||
| index("board_is_archived_idx").on(table.isArchived), |
hjball
left a comment
hjball
left a comment
There was a problem hiding this comment.
Thanks for your patience with this one @eliott-herbert-byrnes
It's looking great, just a couple of requested changes:
- Revert the changes under
/locales(handled on merge now) - Replace the archive and unarchived endpoints with
update
You'll also need to reorder the migrations (easiest way to do this is just to remove your entry from _journal, delete your snapshot and migration file, then regenerate). This is becoming a common blocker so I'm going to look into a workflow to handle migration conflicts automatically)
…e endpoints. Reorder migrations
Should be all sorted! lmk if there are any further changes needed. |
2 participants
Uh oh!
There was an error while loading. Please reload this page.