Skip to content

Refactor code formatting check workflow#2328

Merged
andy840119 merged 7 commits intokaraoke-dev:masterfrom
CloneWith:patch/github-ci
Jun 21, 2025
Merged

Refactor code formatting check workflow#2328
andy840119 merged 7 commits intokaraoke-dev:masterfrom
CloneWith:patch/github-ci

Conversation

@CloneWith
Copy link
Copy Markdown
Contributor

Resolves #2063.

The workflow mostly comes from ppy's CI action configuraion, which should work in most cases. And it would be good to have a try on this branch first...

@andy840119
Copy link
Copy Markdown
Member

image

Project name need to be changed.

Copy link
Copy Markdown
Member

@andy840119 andy840119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.
Maybe can ignore the dotnet build step for now.

@andy840119
Copy link
Copy Markdown
Member

As CI is already working, make the PR merge.
Rest of the CI error will be deal with other PR.

@andy840119 andy840119 merged commit 39ba12b into karaoke-dev:master Jun 21, 2025
3 of 5 checks passed
@CloneWith CloneWith deleted the patch/github-ci branch June 21, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prettier the code and check if formatted in the CI

2 participants