Rewrite logic of getting overlay placement container#2333
Merged
andy840119 merged 1 commit intokaraoke-dev:masterfrom Aug 27, 2025
Merged
Rewrite logic of getting overlay placement container#2333andy840119 merged 1 commit intokaraoke-dev:masterfrom
andy840119 merged 1 commit intokaraoke-dev:masterfrom
Conversation
Member
|
LGTM for me if it works 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest version of this ruleset won't display the changelog overlay properly. It would appear in the FPS counter display at the bottom right corner... So I make this PR to attempt to resolve this issue.
For stability and performance concerns, it should be better to use
WaveOverlayContainerto locate our target. Below is what I got when debugging for reference: