If deploy.user is set, use it also in rsync command#113
Open
nlsrchtr wants to merge 1 commit intokarlfreeman:masterfrom
Open
If deploy.user is set, use it also in rsync command#113nlsrchtr wants to merge 1 commit intokarlfreeman:masterfrom
nlsrchtr wants to merge 1 commit intokarlfreeman:masterfrom
Conversation
|
This fixed this issue for me, hope this pull request is accepted soon. |
|
+1 |
1 similar comment
|
👍 |
|
thanks! |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a small bug in the rsync strategy. If the user was explicitly set, it wasn't passed into the rsync command, due to local / global method / variable name clashes.