Update dependencies and fix test#128
Open
nulltask wants to merge 7 commits intokarlfreeman:masterfrom
Open
Conversation
Middleman 4.1.11+ is no longer support Ruby < 2.2.0: middleman/middleman@07651c63a693bff183af907d27 4641d08f598565
Reference: https://github.com/codeclimate/ruby-test-reporter/blob/master/CHANGELOG. md#v100-2016-11-03
nulltask
changed the title
Contributor
Author
|
@karlfreeman I fixed to pass all test. Please review :) /cc @middleman-contrib/people |
runlevel5
reviewed
Oct 8, 2017
| Cucumber::Rake::Task.new(:cucumber, 'Run features that should pass') do |t| | ||
| exempt_tags = ['--tags ~@wip'] | ||
| t.cucumber_opts = "--color #{exempt_tags.join(' ')} --strict --format #{ENV['CUCUMBER_FORMAT'] || 'Fivemat'}" | ||
| t.cucumber_opts = "--color #{exempt_tags.join(' ')} --strict # --format #{ENV['CUCUMBER_FORMAT'] || 'Fivemat'}" |
Contributor
There was a problem hiding this comment.
Is there any reason why the formatter option is commented out?
runlevel5
reviewed
Oct 8, 2017
| require 'middleman-core' | ||
| require 'middleman-core/step_definitions' | ||
|
|
||
| require 'codeclimate-test-reporter' |
Contributor
There was a problem hiding this comment.
Is this project still using Codeclimate?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump version to middleman >= 4.1.11 and updated some dependencies to pass tests. Also I updated travis.yml. Middleman 4.1.11+ is no longer support Ruby < 2.2.2