Correctly start & stop edge browser#9
Open
jslegers wants to merge 9 commits intokarma-runner:masterfrom
Open
Conversation
Allow paths that have spaces to be run correctly
Add missing signal" argument
jslegers
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commits in this pull request involve the following changes :
scripts/start_edge.ps1now starts correctly, even if it is in a path with a spacescripts/start_edge.ps1now resets Edge's config before starting Edge, to remove all open tabs (implementation based on this script)scripts/start_stop.ps1has been replaced bytaskkill /t /f /im MicrosoftEdge.exe(as in version 0.4.2), becausescripts/start_stop.psdidn't work (at least it didn't on our test machines)_onProcessExitnow has a 3rdsignalargument, in alignment with the current Karma API. Not having this argument caused it to behave unexpectedly when using the latest version of Karma.Unit tests are updated to accept the aforementioned changes in behavior