Skip to content

_onProcessExit is missing "signal" parameter#105

Open
jslegers wants to merge 1 commit intokarma-runner:masterfrom
jslegers:master
Open

_onProcessExit is missing "signal" parameter#105
jslegers wants to merge 1 commit intokarma-runner:masterfrom
jslegers:master

Conversation

@jslegers
Copy link

In recent versions of Karma, _onProcessExit has a third parameter called signal, in between code & errorOutput.

karma-ie-launcher is missing this parameter.

In recent versions of Karma, _onProcessExit has a third parameter called "signal", in between "code" & "errorOutput"
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jslegers
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants