Feat: Promote ControllerPriorityQueue to beta#7200
Feat: Promote ControllerPriorityQueue to beta#7200zach593 wants to merge 2 commits intokarmada-io:masterfrom
Conversation
The feature gate is now enabled by default and considered stable for broader adoption. Signed-off-by: zach593 <zach_li@outlook.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @zach593, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request advances the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request promotes the ControllerPriorityQueue feature gate to beta and enables it by default. The changes in pkg/features/features.go correctly update the feature gate's status from alpha to beta and set its default value to true. The changes are straightforward, correct, and align with the goal of the pull request. The code looks good.
There was a problem hiding this comment.
Pull request overview
This PR promotes the ControllerPriorityQueue feature gate from alpha (introduced in v1.15) to beta status in v1.17, enabling it by default. The feature allows controllers to prioritize processing recent cluster changes first during startup, reducing perceived backlog and improving responsiveness, though it may increase overall reconciliation frequency. This promotion is part of the broader performance optimization initiative tracked in issue #7072.
Changes:
- Updated feature gate status from alpha to beta with default enabled
- Updated version tracking comment from v1.15 to v1.17
- Changed feature gate configuration to enable by default
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7200 +/- ##
==========================================
+ Coverage 42.00% 42.04% +0.04%
==========================================
Files 874 874
Lines 53448 53454 +6
==========================================
+ Hits 22450 22476 +26
+ Misses 29303 29291 -12
+ Partials 1695 1687 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Hongcai Ren <renhongcai@huawei.com> Signed-off-by: zach593 <zach_li@outlook.com>
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR promotes the
ControllerPriorityQueuefeature gate to beta and enables it by default. The feature has been validated through sufficient testing and real-world usage, and is now considered stable for broader adoption.Which issue(s) this PR fixes:
Fixes #
Part of #7072
Special notes for your reviewer:
The feature has been exercised in production environments and has demonstrated stability and performance benefits. No behavioral changes are introduced other than enabling it by default.
Does this PR introduce a user-facing change?: