Skip to content

Comments

Feat: Promote ControllerPriorityQueue to beta#7200

Open
zach593 wants to merge 2 commits intokarmada-io:masterfrom
ctripcloud:pq
Open

Feat: Promote ControllerPriorityQueue to beta#7200
zach593 wants to merge 2 commits intokarmada-io:masterfrom
ctripcloud:pq

Conversation

@zach593
Copy link
Contributor

@zach593 zach593 commented Feb 14, 2026

What type of PR is this?
/kind feature


What this PR does / why we need it:

This PR promotes the ControllerPriorityQueue feature gate to beta and enables it by default. The feature has been validated through sufficient testing and real-world usage, and is now considered stable for broader adoption.


Which issue(s) this PR fixes:

Fixes #

Part of #7072


Special notes for your reviewer:

The feature has been exercised in production environments and has demonstrated stability and performance benefits. No behavioral changes are introduced other than enabling it by default.


Does this PR introduce a user-facing change?:

karmada-controller-manager, karmada-agent: `ControllerPriorityQueue` is promoted to beta and enabled by default.

The feature gate is now enabled by default and considered stable for broader adoption.

Signed-off-by: zach593 <zach_li@outlook.com>
Copilot AI review requested due to automatic review settings February 14, 2026 06:49
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 14, 2026
@karmada-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xishanyongye-chang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist
Copy link

Summary of Changes

Hello @zach593, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request advances the ControllerPriorityQueue feature gate to beta status and activates it by default. This promotion signifies the feature's maturity and stability, having undergone sufficient testing and real-world validation. The change aims to make this performance-enhancing feature more accessible to users without introducing any behavioral modifications beyond its default enablement.

Highlights

  • Feature Gate Promotion: The ControllerPriorityQueue feature gate has been promoted from alpha to beta, indicating its maturity and stability.
  • Default Enablement: The ControllerPriorityQueue feature is now enabled by default, making its benefits accessible without manual configuration.
  • Version Update: The associated version for the ControllerPriorityQueue feature gate has been updated from v1.15 to v1.17 to reflect its new beta status.
Changelog
  • pkg/features/features.go
    • Updated the ControllerPriorityQueue feature gate's stability level from alpha: v1.15 to beta: v1.17.
    • Changed the default enablement of ControllerPriorityQueue from false to true and its PreRelease status from featuregate.Alpha to featuregate.Beta.
Activity
  • The pull request was created by zach593.
  • The ControllerPriorityQueue feature gate is promoted to beta.
  • The feature is now enabled by default.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 14, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request promotes the ControllerPriorityQueue feature gate to beta and enables it by default. The changes in pkg/features/features.go correctly update the feature gate's status from alpha to beta and set its default value to true. The changes are straightforward, correct, and align with the goal of the pull request. The code looks good.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR promotes the ControllerPriorityQueue feature gate from alpha (introduced in v1.15) to beta status in v1.17, enabling it by default. The feature allows controllers to prioritize processing recent cluster changes first during startup, reducing perceived backlog and improving responsiveness, though it may increase overall reconciliation frequency. This promotion is part of the broader performance optimization initiative tracked in issue #7072.

Changes:

  • Updated feature gate status from alpha to beta with default enabled
  • Updated version tracking comment from v1.15 to v1.17
  • Changed feature gate configuration to enable by default

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.04%. Comparing base (bcff69b) to head (9398615).
⚠️ Report is 2 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7200      +/-   ##
==========================================
+ Coverage   42.00%   42.04%   +0.04%     
==========================================
  Files         874      874              
  Lines       53448    53454       +6     
==========================================
+ Hits        22450    22476      +26     
+ Misses      29303    29291      -12     
+ Partials     1695     1687       -8     
Flag Coverage Δ
unittests 42.04% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Hongcai Ren <renhongcai@huawei.com>
Signed-off-by: zach593 <zach_li@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants