Skip to content

fix: add curl fallback in deploy-k8s-metrics-server.sh for macOS comp… #7274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Krishiv-Mahajan wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: add curl fallback in deploy-k8s-metrics-server.sh for macOS comp… #7274

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4620091
fix: add curl fallback in deploy-k8s-metrics-server.sh for macOS comp…
Krishiv-Mahajan Mar 10, 2026
cdc40ee
adding a variable for server-url
Krishiv-Mahajan Mar 11, 2026
8d31c46
adding_proper_wget_fallback
Krishiv-Mahajan Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion hack/deploy-k8s-metrics-server.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,16 @@ fi
MEMBER_CLUSTER_NAME=$2

# get deploy yaml
wget https://github.com/kubernetes-sigs/metrics-server/releases/download/v0.6.3/components.yaml -O "${_tmp}/components.yaml"
METRICS_SERVER_URL="https://github.com/kubernetes-sigs/metrics-server/releases/download/v0.6.3/components.yaml"
# Prefer curl (available on macOS + Linux); fall back to wget on failure; fail with a clear error if both fail
if command -v curl &>/dev/null && curl -fsSL "${METRICS_SERVER_URL}" -o "${_tmp}/components.yaml"; then
:
elif command -v wget &>/dev/null && wget -qO "${_tmp}/components.yaml" "${METRICS_SERVER_URL}"; then
:
else
echo "ERROR: failed to download metrics-server components.yaml. Please ensure curl or wget is installed and network access is available."
exit 1
fi
sed -i'' -e 's/args:/args:\n - --kubelet-insecure-tls=true/' "${_tmp}/components.yaml"

# deploy metrics-server in member cluster
Expand Down
Loading