Automated cherry pick of #7185: fix unrendered templates#7330
Conversation
after upgrade some of `{{ ca_crt }}` were unrendered in the static-resources configmap
this is because `kubectl -o yaml` wraps long lines:
https://stackoverflow.com/questions/65996363/generating-yaml-output-using-kubectl-result-in-splits-line
Signed-off-by: Nikita Sokolov <faucct@tracto.ai>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This cherry-picked pull request resolves a critical issue in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request consistently updates kubectl get configmap commands to output in JSON format instead of YAML. This change is applied across the pre-upgrade-job.yaml template, the customresourceinterpreter example's README.md, and both pre-run-e2e.sh and post-run-e2e.sh scripts. I have no feedback to provide.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.16 #7330 +/- ##
=============================================
Coverage 46.69% 46.69%
=============================================
Files 699 699
Lines 48200 48200
=============================================
Hits 22506 22506
Misses 23999 23999
Partials 1695 1695
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Cherry pick of #7185 on release-1.16.
#7185: fix unrendered templates, Part of #7292
For details on the cherry pick process, see the cherry pick requests page.