Skip to content

Automated cherry pick of #7185: fix unrendered templates#7330

Open
AbhinavPInamdar wants to merge 1 commit intokarmada-io:release-1.16from
AbhinavPInamdar:automated-cherry-pick-of-#7185-upstream-release-1.16
Open

Automated cherry pick of #7185: fix unrendered templates#7330
AbhinavPInamdar wants to merge 1 commit intokarmada-io:release-1.16from
AbhinavPInamdar:automated-cherry-pick-of-#7185-upstream-release-1.16

Conversation

@AbhinavPInamdar
Copy link
Copy Markdown
Contributor

@AbhinavPInamdar AbhinavPInamdar commented Mar 26, 2026

Cherry pick of #7185 on release-1.16.
#7185: fix unrendered templates, Part of #7292
For details on the cherry pick process, see the cherry pick requests page.

`karmada-chart`: Fixed unrendered `{{ ca_crt }}` during upgrades.

after upgrade some of `{{ ca_crt }}` were unrendered in the static-resources configmap

this is because `kubectl -o yaml` wraps long lines:
https://stackoverflow.com/questions/65996363/generating-yaml-output-using-kubectl-result-in-splits-line

Signed-off-by: Nikita Sokolov <faucct@tracto.ai>
@karmada-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign whitewindmills for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 26, 2026
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This cherry-picked pull request resolves a critical issue in the karmada-chart where certificate authority (CA) templates were failing to render during upgrades. The fix involves a subtle but important change in how kubectl output is handled, ensuring that necessary substitutions occur as intended across various scripts and configurations.

Highlights

  • Template Rendering Fix: Addressed an issue where {{ ca_crt }} templates were not being rendered correctly during upgrades within the karmada-chart.
  • Output Format Consistency: Updated kubectl get configmap commands from using -o yaml to -o json to ensure consistent and reliable string substitution with sed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request consistently updates kubectl get configmap commands to output in JSON format instead of YAML. This change is applied across the pre-upgrade-job.yaml template, the customresourceinterpreter example's README.md, and both pre-run-e2e.sh and post-run-e2e.sh scripts. I have no feedback to provide.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.69%. Comparing base (4a83ef2) to head (f11b026).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.16    #7330   +/-   ##
=============================================
  Coverage         46.69%   46.69%           
=============================================
  Files               699      699           
  Lines             48200    48200           
=============================================
  Hits              22506    22506           
  Misses            23999    23999           
  Partials           1695     1695           
Flag Coverage Δ
unittests 46.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhzhuang-zju zhzhuang-zju mentioned this pull request Mar 30, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants