Karmada Metrics Documentation Improvement#610
Open
shivansh-bhatnagar18 wants to merge 8 commits intokarmada-io:mainfrom
Open
Karmada Metrics Documentation Improvement#610shivansh-bhatnagar18 wants to merge 8 commits intokarmada-io:mainfrom
shivansh-bhatnagar18 wants to merge 8 commits intokarmada-io:mainfrom
Conversation
karmada-bot
added
the
kind/documentation
karmada-bot
added
the
do-not-merge/contains-merge-commits
Contributor
|
Welcome @shivansh-bhatnagar18! It looks like this is your first PR to karmada-io/website 🎉 |
karmada-bot
added
the
size/L
Improvised the documentation for setting up the local development server Signed-off-by: Shivansh Bhatnagar <shivansh.bhatnagar.mat22@itbhu.ac.in>
Signed-off-by: B1F030 <b1fzhang@gmail.com> Signed-off-by: Shivansh Bhatnagar <shivansh.bhatnagar.mat22@itbhu.ac.in>
Signed-off-by: B1F030 <b1fzhang@gmail.com> Signed-off-by: Shivansh Bhatnagar <shivansh.bhatnagar.mat22@itbhu.ac.in>
Signed-off-by: Shivansh Bhatnagar <shivansh.bhatnagar.mat22@itbhu.ac.in>
Signed-off-by: Shivansh Bhatnagar <shivansh.bhatnagar.mat22@itbhu.ac.in>
Signed-off-by: Shivansh Bhatnagar <shivansh.bhatnagar.mat22@itbhu.ac.in>
Signed-off-by: Shivansh Bhatnagar <shivansh.bhatnagar.mat22@itbhu.ac.in>
Signed-off-by: Shivansh Bhatnagar <shivansh.bhatnagar.mat22@itbhu.ac.in>
shivansh-bhatnagar18
force-pushed
the
metricsdocumentation
branch
from
14053a4 to
42a1d4e
Compare
karmada-bot
added
size/XL
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
shivansh-bhatnagar18
force-pushed
the
metricsdocumentation
branch
from
8bb8208 to
42a1d4e
Compare
karmada-bot
added
size/XL
windsonsea
reviewed
Jul 4, 2024
Member
windsonsea
left a comment
windsonsea
left a comment
There was a problem hiding this comment.
LGTM for those addition, removal, and replacement of $
Member
|
ping @shivansh-bhatnagar18, could you take a look those conflicts and resolve it? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Earlier, the documentation for Karmada metrics was not segregated according to their components and there was no clear demo/instructions as to how to query these metrics which is improved in this PR
Which issue(s) this PR fixes:
Fixes #425
Special notes for your reviewer: