Modified the Karmada tutorial description#614
Open
shivansh-bhatnagar18 wants to merge 2 commits intokarmada-io:mainfrom
Open
Modified the Karmada tutorial description#614shivansh-bhatnagar18 wants to merge 2 commits intokarmada-io:mainfrom
shivansh-bhatnagar18 wants to merge 2 commits intokarmada-io:mainfrom
Conversation
karmada-bot
added
the
kind/documentation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
karmada-bot
added
the
size/M
Signed-off-by: Shivansh Bhatnagar <shivansh.bhatnagar.mat22@itbhu.ac.in>
Signed-off-by: Shivansh Bhatnagar <shivansh.bhatnagar.mat22@itbhu.ac.in>
shivansh-bhatnagar18
force-pushed
the
resourcemigrationdocs
branch
from
8697ac6 to
c0e2471
Compare
windsonsea
reviewed
Jul 5, 2024
|
|
||
| ```shell | ||
| $ kubectl --context karmada-apiserver apply -f /tmp/pp-for-nginx-app.yaml | ||
| kubectl --context karmada-apiserver apply -f /tmp/pp-for-nginx-app.yaml |
Member
There was a problem hiding this comment.
Suggested change
| kubectl --context karmada-apiserver apply -f /tmp/pp-for-nginx-app.yaml | |
| $ kubectl --context karmada-apiserver apply -f /tmp/pp-for-nginx-app.yaml |
This $ can be remained. Line 1 is command and line 2 is output.
| - **member1**: | ||
|
|
||
| ```shell | ||
| kubectl --context member1 get deploy -o wide |
Member
There was a problem hiding this comment.
Suggested change
| kubectl --context member1 get deploy -o wide | |
| $ kubectl --context member1 get deploy -o wide |
| NAME READY UP-TO-DATE AVAILABLE AGE CONTAINERS IMAGES SELECTOR | ||
| nginx-deploy 2/2 2 2 5m24s nginx nginx:latest app=nginx | ||
|
|
||
| kubectl --context member1 get svc -o wide |
Member
There was a problem hiding this comment.
Suggested change
| kubectl --context member1 get svc -o wide | |
| $ kubectl --context member1 get svc -o wide |
| - **member2**: | ||
|
|
||
| ```shell | ||
| kubectl --context member2 get deploy -o wide |
Member
There was a problem hiding this comment.
Suggested change
| kubectl --context member2 get deploy -o wide | |
| $ kubectl --context member2 get deploy -o wide |
| NAME READY UP-TO-DATE AVAILABLE AGE CONTAINERS IMAGES SELECTOR | ||
| nginx-deploy 2/2 2 2 5m24s nginx nginx:latest app=nginx | ||
|
|
||
| kubectl --context member2 get svc -o wide |
Member
There was a problem hiding this comment.
Suggested change
| kubectl --context member2 get svc -o wide | |
| $ kubectl --context member2 get svc -o wide |
| nginx-svc NodePort 10.13.161.255 <none> 80:30000/TCP 54s app=nginx | ||
| ``` | ||
|
|
||
| This confirms that the higher priority `PropagationPolicy` has effectively propagated the `nginx` application resources to both `member1` and `member2` clusters, meeting the desired propagation requirements. |
Member
There was a problem hiding this comment.
Suggested change
| This confirms that the higher priority `PropagationPolicy` has effectively propagated the `nginx` application resources to both `member1` and `member2` clusters, meeting the desired propagation requirements. | |
| This confirms that the higher priority `PropagationPolicy` has effectively propagated the `nginx` application | |
| resources to both `member1` and `member2` clusters, meeting the desired propagation requirements. |
Wrapping long lines can make it prettier in the editing mode.
chaosi-zju
reviewed
Jul 5, 2024
Comment on lines
+183
to
+184
|
|
||
|
|
Member
There was a problem hiding this comment.
hi, why here added two empty line?
chaosi-zju
reviewed
Jul 5, 2024
|
|
||
| As you see, you shall find `nginx` application related resource are all propagated to `member2` cluster, | ||
| which means the higher priority `PropagationPolicy` does work. No newline at end of file | ||
| You should see the `nginx` application related resources originally in `member1` also propagated to `member2`, completing the migration of resources : |
Member
There was a problem hiding this comment.
Thank you for finding and correcting the mistake here!
Member
|
I'm so sorry that I missed this PR. Do you still have time to fix the comment above? We will merge it ASAP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it
Initially, the resource migration documentation led to a misunderstanding that the
nginxapplication-related resources are propagated tomember2but they are also propagated tomember1Which issue(s) this PR fixes:
Fixes #486