This repository was archived by the owner on Jun 30, 2018. It is now read-only.
Fixing settings failure problem where there is no index#816
Open
hexgnu wants to merge 1 commit intokarmi:masterfrom
Open
Fixing settings failure problem where there is no index#816hexgnu wants to merge 1 commit intokarmi:masterfrom
hexgnu wants to merge 1 commit intokarmi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
If you have an index that doesn't exist like Tire.index('foobaz') and call the method settings on it, it will error out due to a nil trying to be accessed like a hash.
This aims to fix that by returning a blank hash instead.
Since Tire.index('foobaz') returns an index even though one isn't made I figured this would be the approach you would like.
How to test
I put a spec in there to ensure that the error doesn't happen in the future.
Let me know if there's something I can change! Thanks!