This repository was archived by the owner on Jun 30, 2018. It is now read-only.
:class instance of a property value should be able to reference the "embedding" doc (or parent)#865
Open
FestivalBobcats wants to merge 2 commits intokarmi:masterfrom
Open
:class instance of a property value should be able to reference the "embedding" doc (or parent)#865FestivalBobcats wants to merge 2 commits intokarmi:masterfrom
FestivalBobcats wants to merge 2 commits intokarmi:masterfrom
Conversation
Author
|
And apologies for the barrage of successive pull requests... |
Owner
|
I understand the motivation, and think this would work, but I'm just a bit wary about changing the instantiation in If we could somehow keep the method signature, I'm all for adding it, ideally "injecting" it from the outside? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the style of Mongoid's embedded documents, it would be nice (really nice) for property classes to reference their respective "owner" or "parent" docs (
article.comments.first.article). The example below will hopefully illustrate the problem. The only existing solutions are accessor methods in the root model (e.g.article.comment_posted_within(comment)) or storing the needed attributes from the root model (such as :created_at in the test) within each embedded object, which is probably a little overkill.