Claude/fix hoa screenshot workflow 011 cv2r m7i ga7du kggjv lgpn #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes multiple fixes to enable the screenshot generation workflow to run successfully: 1. **Workflow Configuration** (.github/workflows/generate-screenshots.yml) - Added pull_request trigger for main/master branches - Workflow now triggers on PRs when frontend files change 2. **Backend Fixes** (backend/src/config/sentry.js) - Fixed Sentry handlers to return no-op middleware when Sentry DSN is not configured - Prevents crashes when Sentry is disabled in test environment 3. **Frontend Configuration** (frontend/vite.config.ts) - Configured Vite to run on port 3000 (matching Playwright expectations) - Added API proxy to backend on port 3001 4. **Playwright Configuration** (frontend/playwright.config.ts) - Added Chrome launch args for containerized environments (--no-sandbox, --disable-setuid-sandbox, etc.) - Configured for better compatibility with CI/CD environments 5. **Test Fixes** (frontend/e2e/generate-screenshots.spec.ts) - Fixed ES module __dirname issue using fileURLToPath - Ensures screenshot directory path is correctly resolved 6. **Database Seeders** - Updated seed-test-data.js to use correct database paths - Partially updated seeder schema to match database (users table) These changes enable the screenshot workflow to run in GitHub Actions and generate user guide screenshots automatically.
- Removed --single-process and --disable-web-security flags that cause browser crashes - Updated test to use storageState for better auth session management - Added .auth directory to gitignore for auth tokens - Improved error handling with try-catch for visibility checks - Fixed ES module compatibility issues These changes improve test stability, especially in CI/CD environments like GitHub Actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe the change. Link issues.
Type of change
How to test
Steps for reviewers to validate locally.
Checklist