use 1-sqrt warmdown shape for LR schedule#513
Open
spjosyula wants to merge 1 commit intokarpathy:masterfrom
Open
use 1-sqrt warmdown shape for LR schedule#513spjosyula wants to merge 1 commit intokarpathy:masterfrom
spjosyula wants to merge 1 commit intokarpathy:masterfrom
Conversation
svlandeg
reviewed
Feb 9, 2026
Collaborator
svlandeg
left a comment
There was a problem hiding this comment.
Have you done any experiments to validate the change?
Contributor
Author
No experiments yet. As noted in the description, this needs a d12 run. Why I think it's worth one:
The gap is that those results were with AdamW and if the shape shifts the optimal warmdown ratio, that may need |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace linear warmdown with 1-sqrt cooldown shape (
LR = 1 - sqrt(x)) inbase_train.pyandchat_sft.py. Leftchat_rl.pyunchanged since its schedule is pure decay with no stable phase.The warmdown shape has never been changed since it was inherited from
modded-nanogpt: the ratio was swept (0.2 → 0.4 → 0.5) but the linear
curve itself was kept as-is. 1-sqrt drops LR faster early in warmdown
then flattens, which should reduce gradient noise sooner while keeping
more steps at low-but-nonzero LR for convergence.
Needs a d12 run to validate.