Remove inherited parameters from scripts#568
Open
svlandeg wants to merge 3 commits intokarpathy:masterfrom
Open
Remove inherited parameters from scripts#568svlandeg wants to merge 3 commits intokarpathy:masterfrom
svlandeg wants to merge 3 commits intokarpathy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this edit,
sftinherits some settings from the pretraining phase (which is nice). So we can delete them from thechat_sftcommands in the run scripts, ensuring that changing them once in thebase_traincommand would automatically copy the new value over tochat_sft.I would personally add in
model-tagto be more explicit about which checkpoint to start from, but I decided to leave it out of this PR for simplicity.