fix: guard target-param-data-ratio against zero to avoid ZeroDivision…#579
Open
suraj-self wants to merge 3 commits intokarpathy:masterfrom
Open
fix: guard target-param-data-ratio against zero to avoid ZeroDivision…#579suraj-self wants to merge 3 commits intokarpathy:masterfrom
suraj-self wants to merge 3 commits intokarpathy:masterfrom
Conversation
Author
|
Hi @svlandeg However, would you prefer the script to gracefully fall back to the default Chinchilla ratio (10.5) when |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a sanity check for the
--target-param-data-ratioargument. Fix for #578ZeroDivisionErrorwhen the user accidentally provides0."target-param-data-ratio must be positive (or -1 to disable)".-1flag used to disable scaling-based iterations.Logs