Fix memory-report error with gptel's transient history #1043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k#1032) When memory-report tries to compute the size of gptel's transient history data, it fails with an out-of-bounds error when accessing slots of the gptel-gemini struct. This happens because the struct contains a bytecode function in its :url slot. The fix prevents storing the backend struct in transient's history by setting history-key and history-default to nil in the gptel-provider-variable class. This avoids the memory-report error while maintaining full functionality of the transient menu. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
memory-reportfails when trying to compute the size of gptel's transient historyProblem
When
memory-reporttries to traverse the gptel-gemini struct stored intransient-history, it encounters an out-of-bounds error when accessing the struct's slots. This happens because the struct contains a compiled function (bytecode) in its:urlslot, whichmemory-reportdoesn't handle correctly.Solution
The fix adds
history-keyandhistory-defaultslots (both set tonil) to thegptel-provider-variableclass. This prevents transient from storing the backend struct in its history, avoiding the memory-report error while maintaining full functionality of the transient menu.Test plan
gptel-transient-memory-test.elto verify the fix🤖 Generated with Claude Code