Fix gptel-auto-scroll when streaming at end of buffer #1088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes karthink#893 The gptel-auto-scroll function was called from within save-excursion during streaming responses. When point was at the end of the buffer, scroll-up-command would fail, preventing the window from following streaming output. This fix defers the scroll operation using run-at-time, allowing it to execute after save-excursion completes. The implementation also: - Captures the insertion position before deferring - Uses recenter instead of scroll-up-command for more reliable positioning - Passes window and position as explicit lambda parameters 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #893
Summary
The
gptel-auto-scrollfunction was called from withinsave-excursionduring streaming responses. When point was at the end of the buffer,scroll-up-commandwould fail, preventing the window from following streaming output.Changes
This fix defers the scroll operation using
run-at-time, allowing it to execute aftersave-excursioncompletes. The implementation also:recenter -1instead ofscroll-up-commandfor more reliable positioning at window bottomTesting
The fix addresses the reproduction steps in #893:
(add-hook 'gptel-post-stream-hook 'gptel-auto-scroll)gptel-sendwith text longer than viewportExpected: Window scrolls to follow streaming text
Result: Window now correctly scrolls
Comparison to PR #894
This implementation improves on PR #894 by:
recenter -1for consistent bottom-of-window positioning🤖 Generated with Claude Code