Skip to content

gptel-openai: Validate MIME types for media files #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gptel-openai: Validate MIME types for media files #1089

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions gptel-openai.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,14 +473,24 @@ format."
for n upfrom 1
with last = (length parts)
for text = (plist-get part :text)
for mime = (plist-get part :mime)
for media = (plist-get part :media)
if text do
(and (or (= n 1) (= n last)) (setq text (gptel--trim-prefixes text)))
and if text
collect `(:type "text" :text ,text) into parts-array end
else if media collect
else if media
do
;; Validate that media is a supported image format
(unless (and mime (member mime '("image/jpeg" "image/png" "image/gif" "image/webp")))
(error (concat "(gptel-openai) Request aborted: "
"OpenAI API only supports image formats (JPEG, PNG, GIF, WebP). "
"Unsupported MIME type: %s. "
"For PDF support, use native Anthropic or Gemini backends")
(or mime "unknown")))
and collect
`(:type "image_url"
:image_url (:url ,(concat "data:" (plist-get part :mime)
:image_url (:url ,(concat "data:" mime
";base64," (gptel--base64-encode media))))
into parts-array
else if (plist-get part :textfile) collect
Expand Down