Skip to content

Fix gptel-auto-scroll not working when insertion is at end of buffer #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix gptel-auto-scroll not working when insertion is at end of buffer #894

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bcac5b3
Fix gptel-auto-scroll when at end of buffer
JDNdeveloper Jun 4, 2025
41376ec
Add back comment
JDNdeveloper Jun 4, 2025
0f509e9
Fix comment
JDNdeveloper Jun 4, 2025
b693bec
gptel: Move auto-scroll delay up to the outside
karthink Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions gptel.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,13 +1009,14 @@ Later plists in the sequence take precedence over earlier ones."
"Scroll window if LLM response continues below viewport.

Note: This will move the cursor."
(when-let* ((win (get-buffer-window (current-buffer) 'visible))
((not (pos-visible-in-window-p (point) win)))
(scroll-error-top-bottom t))
(condition-case nil
(with-selected-window win
(scroll-up-command))
(error nil))))
(run-at-time ;Scheduled on the event loop to call from outside save-excursion
0 nil (lambda ()
(when-let* ((win (get-buffer-window (current-buffer) 'visible))
((not (pos-visible-in-window-p (point) win)))
(scroll-error-top-bottom t))
(condition-case nil
(with-selected-window win (scroll-up-command))
(error nil))))))

(defun gptel-beginning-of-response (&optional _ _ arg)
"Move point to the beginning of the LLM response ARG times."
Expand Down