Skip to content

gptel: Allow dynamically overriding preset parameters during apply #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

gptel: Allow dynamically overriding preset parameters during apply #940

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
27fd2a7
Allow request-time preset overrides via the PRE function
kmontag Jun 29, 2025
f74233c
Improve plist detection
kmontag Jul 1, 2025
d529056
Replace keys in the existing preset when overriding via :pre
kmontag Jul 1, 2025
2a24492
Only allow modifying keys which are already present in the spec
kmontag Jul 2, 2025
6810734
Cleaner modification of preset plist during override
kmontag Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions gptel.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3525,7 +3525,19 @@ PARENTS is a preset name (or list of preset names) to apply before this
one.

PRE and POST are functions to run before and after the preset is
applied. They take no arguments.
applied. They take no arguments. PRE can return a plist containing
other keys from the preset's spec, which will override the spec's values
during the current application. Use this to adjust the preset based on
the current environment. For example:

(gptel-make-preset 'enable-tools
;; Must specify a default value for any keys that may be overridden.
:use-tools t
:pre (lambda ()
;; If the value is already set to something non-nil like 'force,
;; override the default with the current value.
(when gptel-use-tools
`(:use-tools ,gptel-use-tools)))

BACKEND is the gptel-backend to set, or its name (like \"ChatGPT\").

Expand Down Expand Up @@ -3609,7 +3621,21 @@ example) apply the preset buffer-locally."
preset))))
(setq preset (cons preset spec))))
(unless setter (setq setter #'set))
(when-let* ((func (plist-get (cdr preset) :pre))) (funcall func))
(when-let* ((func (plist-get (cdr preset) :pre))
(result (funcall func)))
;; If the :pre function returns a plist, merge it with the main spec.
(when (plistp result)
(setq preset (copy-sequence preset))
(cl-loop for (key value) on result by #'cddr do
(let ((spec (cdr preset)))
(if (plist-member spec key)
(setcdr preset (plist-put spec key value))
(display-warning
'(gptel presets)
(format (concat
"gptel preset \"%s\": :pre function returned "
"key %s not present in preset spec, ignoring.")
(car preset) key)))))))
(when-let* ((parents (plist-get (cdr preset) :parents)))
(mapc #'gptel--apply-preset (ensure-list parents)))
(map-do
Expand Down