Skip to content

SDK Refactor#1

Open
bh2smith wants to merge 4 commits intomainfrom
sdk-refactor
Open

SDK Refactor#1
bh2smith wants to merge 4 commits intomainfrom
sdk-refactor

Conversation

@bh2smith
Copy link
Member

@bh2smith bh2smith commented Nov 21, 2023

  1. HookBuilder Class with hook generation and post functions.
  2. Refactor the scripts to use hook builder.
  3. Document some methods (still missing some).
  4. Remove a few todos (add a few as well)
  5. create utils and types and constants files.

The constants file could be renamed params and also be responsible for reading env vars and choosing certain values based on chainId (e.g. settlement contract address -- although its the same on gnosis and mainnet) etc...

I am pushing into dev for now, because I wasn't sure if we are allowed to keep working on this.

@netlify
Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for karvest failed.

Name Link
🔨 Latest commit 30774a3
🔍 Latest deploy log https://app.netlify.com/sites/karvest/deploys/655c6782f190030008302276

@bh2smith bh2smith changed the base branch from main to dev November 21, 2023 08:13
@bh2smith bh2smith changed the base branch from dev to main November 21, 2023 08:15
@bh2smith bh2smith requested review from Xalava and jaybuidl November 21, 2023 08:25
@bh2smith
Copy link
Member Author

Seems to be failing this build setup...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant