Conversation
de14094 to
225c0d5
Compare
This should be impossible, though it is difficult to prove.
dhardy
commented
Feb 26, 2026
| //! [`format`]: mod@format | ||
|
|
||
| #![cfg_attr(docsrs, feature(doc_cfg))] | ||
| #![allow(text_direction_codepoint_in_literal)] |
Contributor
Author
There was a problem hiding this comment.
This is required by a new test. Unfortunately Rust does not allow enabling text-direction marks for specific uses only, thus we must enable it at the crate level.
Contributor
Author
|
Although the new tests avoid depending on any font metrics, they still fail on various platforms due to font variations:
|
225c0d5 to
3246e49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Removes the highlight-range functions (already deprecated in #133) since other changes in this PR would break them.
Panic-prevention:
text_glyph_posmatchesindexto more than two positionsNew tests:
Code revisions / clean up:
glyphs_with_effectspart_lengthsGlyphRun::breaksandGlyphRun::glyphs(these previously used left-to-right oredr regardless of text direction)Fixes (many confirmed through interactive testing since tests would be font-specific):
text_glyph_posin shaped (RTL) text using multiple glyphs per text indexBehaviour changes: