UPnP: Periodic External IP Refresh & Outbound Peer Reconnect on Change #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 19, 2025 18:46
…utbound peers on change Previously the external IP (via UPnP) was fetched and mapped only once at node startup; dynamic WAN IP changes (e.g. ISP 24h leases, router reconnects) were not propagated, leaving peers with a stale address until manual restart. This change: Adds periodic external IP refresh in the UPnP port mapping extender (re-uses the existing renew cycle to also call get_external_ip). Detects IP changes and updates the AddressManager best local address. Introduces ExternalIpChangeSink; ConnectionManager implements it to trigger a staggered outbound reconnect so new peers learn the updated public address sooner. Adds set_best_local_address helper. Adds CLI/config flag --disable-ipv6-interface-discovery to skip automatic IPv6 interface scanning while still allowing explicit IPv6 config. Registers ConnectionManager as an external IP change sink.
- Rename init_local_addresses_with_arc -> init_local_addresses (Arc param made name redundant). - Remove unused ConnectionManager methods trigger_outbound_reconnect_simple and reconnect_outbound_gradually (logic now handled internally elsewhere). - Clean up stale UPnP/DynDNS setup comment in daemon. - Minor formatting tidy in UPnP gateway search call.
Collaborator
coderofstuff
left a comment
coderofstuff
left a comment
There was a problem hiding this comment.
initial comments :)
| index_service.as_ref().map(|x| x.notifier()), | ||
| mining_manager, | ||
| flow_context, | ||
| flow_context.clone(), |
Collaborator
There was a problem hiding this comment.
Why is this clone necessary?
| } | ||
|
|
||
| /// Synchronously trigger a staggered outbound reconnect (terminates peers one by one with 30s delays) | ||
| pub fn trigger_outbound_reconnect(&self) { |
Collaborator
There was a problem hiding this comment.
Why is this necessary? When your external IP changes, wouldn't a disconnection already have happened (you disconnect from all your peers) and when you try to reconnect to your peers they would then know your new IP?
|
|
||
| pub use stores::NetAddress; | ||
|
|
||
| pub trait ExternalIpChangeSink: Send + Sync { |
Collaborator
There was a problem hiding this comment.
Why is this called Sink?
| } | ||
| } | ||
|
|
||
| pub fn set_best_local_address(&mut self, address: NetAddress) { |
Collaborator
There was a problem hiding this comment.
I wonder if it's better to handle the TODO in pub fn best_local_address(&mut self) -> Option<NetAddress> { instead
Collaborator
|
Also please rebase and fix the lint and test issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion Invitation
This PR (and upcoming related PRs) is meant to spark discussion on how we can further improve the reliability and usability of Kaspa nodes at home. It is provided as a template and idea starter and does not need to be merged verbatim in its current form.
Summary
Adds automatic periodic refreshing of the external IP obtained via UPnP and propagates changes to the peer layer. The node no longer requires a restart after WAN IP changes (e.g. ISP lease renewals). When the external IP changes, outbound peers are reconnected gradually so the updated address spreads quickly.
Motivation
Previously the external (WAN) IP was fetched exactly once at startup (via UPnP) and never validated again. If the router/ISP changed the IP later, the node continued advertising a stale address until manual restart. This degraded inbound connectivity and peer discovery. The goal: make external IP tracking resilient to dynamic WAN environments with minimal overhead and no startup delays.
Key Changes
get_external_ipeach cycle.set_best_local_address.ExternalIpChangeSinktrait.ExternalIpChangeSinkto trigger a staggered outbound reconnect (avoids a connection storm).--disable-ipv6-interface-discoveryto skip automatic IPv6 interface scanning (explicit IPv6 still honored).Behavior
Configuration
New flag:
Use to suppress automatic IPv6 interface enumeration while still allowing explicit IPv6 configuration.
Testing / Verification
Manual scenarios:
--disable-ipv6-interface-discovery: No automatically added IPv6 addresses.Authorship Note
This PR description was initially drafted with the assistance of an AI tool. I (p4bpj) have carefully reviewed, adjusted where necessary, and confirm that it accurately reflects the implemented changes.