Let wait: and wait_until: accept a symbol #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is more to start a feature discussion than to actually merge this code :)
I use `performs` a lot in my codebase, often with `wait:` and `wait_until:`, at times like this:
```ruby
performs :notify_customer, wait: 1.second
```
but more commonly like this:
```ruby
performs :send_offer, wait_until: ->(nomination) { nomination.earliest_operating_time }
```
In other words, the waiting time is dictated by a method that belongs to the same record.
---
My feature proposal is to be able to rewrite the last example like this:
```ruby
performs :send_offer, wait_until: :earliest_operating_time
```
The (terrible) code in this commit is just to prove that it can be done.
@kaspth is this something you would be interested in? I can write better code if that's the case :)
Owner
|
@claudiob got caught up in a bunch of other work, but yeah, this seems alright to me and helpful if users are passing private methods. |
kaspth
reviewed
Jan 29, 2026
| end | ||
|
|
||
| def wait_until=(value) | ||
| @wait_until_symbol = value if value.is_a?(Symbol) |
Owner
There was a problem hiding this comment.
I wonder if we could use instance_method here to grab the method early? If so, I don't think we'd need special handling below.
Owner
performs :notify_customer, wait: 1.secondI'm curious, is 1 second picked for the example or are you using it in real life too? What cases do you do that for? 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is more to start a feature discussion than to actually merge this code :)
I use
performsa lot in my codebase, often withwait:andwait_until:, at times like this:but more commonly like this:
In other words, the waiting time is dictated by a method that belongs to the same record.
My feature proposal is to be able to rewrite the last example like this:
The (terrible) code in this commit is just to prove that it can be done. @kaspth is this something you would be interested in? I can write better code if that's the case :)