We can't extract Associated Objects from methods ending in ? or =.#42
Merged
We can't extract Associated Objects from methods ending in ? or =.#42
? or =.#42Conversation
Our `method_missing` based proxying is technically eager to hopefully allow us to support more of Active Record's surface area cheaply. It's been working well for over 3 years, but there's some issues. Notably, a `record.respond_to?` check is not enough and there's certain methods we don't want to proxy. Stuff like Active Record's class-level configuration API via `abtract_class?`, `descends_from_active_record?`, `abstract_class=` and `primary_abstract_class=` to name a few. So ideally opting out of proxying methods that end in `?` and `=` should be safe. I'm not including `!` to allow `find_by!` to work. Ref: rubyevents/rubyevents#873
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our
method_missingbased proxying is technically eager to hopefully allow us to support more of Active Record's surface area cheaply. It's been working well for over 3 years, but there's some issues.Notably, a
record.respond_to?check is not enough and there's certain methods we don't want to proxy.Stuff like Active Record's class-level configuration API via
abtract_class?,descends_from_active_record?,abstract_class=andprimary_abstract_class=to name a few.So ideally opting out of proxying methods that end in
?and=should be safe.I'm not including
!to allowfind_by!to work.Ref: rubyevents/rubyevents#873
Ref: #40