cpuset: Fix v2 effective_cpus/mems file names #157
+46
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@jfernandez Good catch and there are some problems with the CI, thanks. |
The cpuset controller was using cgroup v1 file names for effective CPUs and memory nodes on cgroup v2 systems. The file names changed between versions: v1: cpuset.effective_cpus, cpuset.effective_mems v2: cpuset.cpus.effective, cpuset.mems.effective This caused cpuset().effective_cpus to return empty on v2 systems since the files don't exist. The controller already tracks the cgroup version via the v2 flag, so use it to select the correct file names. Fixes: kata-containers#156 Signed-off-by: Jose Fernandez <josef@netflix.com>
jfernandez
force-pushed
the
fix-cpuset-v2-filenames
branch
from
42cb21b to
5487567
Compare
Author
|
@Tim-Zhang could you approve for another CI run? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cpuset controller was using cgroup v1 file names for effective CPUs and memory nodes on cgroup v2 systems. The file names changed between versions:
v1: cpuset.effective_cpus, cpuset.effective_mems
v2: cpuset.cpus.effective, cpuset.mems.effective
This caused cpuset().effective_cpus to return empty on v2 systems since the files don't exist. The controller already tracks the cgroup version via the v2 flag, so use it to select the correct file names.
Fixes: #156